Skip to content

Conversation

@slp
Copy link
Collaborator

@slp slp commented Nov 28, 2025

So far, we were relying on the EFI flavor of libkrun to load the
firmware for us. As we intend to deprecate this flavor, search for the
firmware at well-known locations and use krun_set_firmware() to
configure its path.

Also, link against libkrun instead if libkrun-efi.

Import the EDK2 firmware binary from the current upstream version of
libkrun.

Signed-off-by: Sergio Lopez <slp@redhat.com>
So far, we were relying on the EFI flavor of libkrun to load the
firmware for us. As we intend to deprecate this flavor, search for the
firmware at well-known locations and use krun_set_firmware() to
configure its path.

Also, link against libkrun instead if libkrun-efi.

Signed-off-by: Sergio Lopez <slp@redhat.com>
Since we're now linking against libkrun instead of libkrun-efi,
let's switch the ci to use the slp/krun tap.

Signed-off-by: Sergio Lopez <slp@redhat.com>
Copy link
Member

@tylerfanelli tylerfanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The failing CI test is seemingly because of the krun-efi link name. This should change to krun.

@slp
Copy link
Collaborator Author

slp commented Dec 1, 2025

I've updated the libkrun version in homebrew-krun and now the CI is green. @jakecorrenti PTAL

@jakecorrenti
Copy link
Member

jakecorrenti commented Dec 1, 2025

@slp I'm having some issues building locally. I can't install the new libkrun package due to some tap conflicts:

krunkit on  pr/86:refs/pull/86/head [$] is 📦 v1.1.1 via 🦀 v1.90.0
❯ brew tap slp/krun && brew install libkrun
==> Fetching downloads for: libkrun
Error: Formulae found in multiple taps:
       * slp/krunkit/virglrenderer
       * slp/krun/virglrenderer

Please use the fully-qualified name (e.g. slp/krunkit/virglrenderer) to refer to a specific formula.

krunkit on  pr/86:refs/pull/86/head [$] is 📦 v1.1.1 via 🦀 v1.90.0 took 2s
❯ brew list | rg virglrenderer
virglrenderer

@slp
Copy link
Collaborator Author

slp commented Dec 2, 2025

@slp I'm having some issues building locally. I can't install the new libkrun package due to some tap conflicts:

Please remove virglrenderer and the homebrew-krunkit tap (brew untap slp/krunkit). Then it should work just fine.

The idea is to add the krunkit formula to homebrew-krun, but we need this one merged first. Then we'll be able to deprecate homebrew-krunkit and have a single repo for everything libkrun-related on macOS, which will be really nice.

@jakecorrenti
Copy link
Member

@slp I'm having some issues building locally. I can't install the new libkrun package due to some tap conflicts:

Please remove virglrenderer and the homebrew-krunkit tap (brew untap slp/krunkit). Then it should work just fine.

The idea is to add the krunkit formula to homebrew-krun, but we need this one merged first. Then we'll be able to deprecate homebrew-krunkit and have a single repo for everything libkrun-related on macOS, which will be really nice.

Thanks, forgot to do brew untap .... All good now.

@jakecorrenti jakecorrenti merged commit 8d0e7a3 into containers:main Dec 2, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants