-
Notifications
You must be signed in to change notification settings - Fork 17
Explicitly load the EFI firmware #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
slp
commented
Nov 28, 2025
Import the EDK2 firmware binary from the current upstream version of libkrun. Signed-off-by: Sergio Lopez <slp@redhat.com>
So far, we were relying on the EFI flavor of libkrun to load the firmware for us. As we intend to deprecate this flavor, search for the firmware at well-known locations and use krun_set_firmware() to configure its path. Also, link against libkrun instead if libkrun-efi. Signed-off-by: Sergio Lopez <slp@redhat.com>
Since we're now linking against libkrun instead of libkrun-efi, let's switch the ci to use the slp/krun tap. Signed-off-by: Sergio Lopez <slp@redhat.com>
tylerfanelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The failing CI test is seemingly because of the krun-efi link name. This should change to krun.
|
I've updated the libkrun version in homebrew-krun and now the CI is green. @jakecorrenti PTAL |
|
@slp I'm having some issues building locally. I can't install the new libkrun package due to some tap conflicts: krunkit on pr/86:refs/pull/86/head [$] is 📦 v1.1.1 via 🦀 v1.90.0
❯ brew tap slp/krun && brew install libkrun
==> Fetching downloads for: libkrun
Error: Formulae found in multiple taps:
* slp/krunkit/virglrenderer
* slp/krun/virglrenderer
Please use the fully-qualified name (e.g. slp/krunkit/virglrenderer) to refer to a specific formula.
krunkit on pr/86:refs/pull/86/head [$] is 📦 v1.1.1 via 🦀 v1.90.0 took 2s
❯ brew list | rg virglrenderer
virglrenderer |
Please remove virglrenderer and the homebrew-krunkit tap ( The idea is to add the krunkit formula to homebrew-krun, but we need this one merged first. Then we'll be able to deprecate homebrew-krunkit and have a single repo for everything libkrun-related on macOS, which will be really nice. |
Thanks, forgot to do |