Skip to content

storage: apply go fix modernizations#874

Merged
Luap99 merged 1 commit into
containers:mainfrom
giuseppe:apply-go-fix-modernizations
May 26, 2026
Merged

storage: apply go fix modernizations#874
Luap99 merged 1 commit into
containers:mainfrom
giuseppe:apply-go-fix-modernizations

Conversation

@giuseppe
Copy link
Copy Markdown
Member

@giuseppe giuseppe commented May 26, 2026

Apply fixes suggested by go fix with Go 1.26:

  • for i := 0; i < N; i++ → for i := range N

@giuseppe
Copy link
Copy Markdown
Member Author

changes already implemented in #872

@giuseppe giuseppe closed this May 26, 2026
@giuseppe giuseppe reopened this May 26, 2026
@github-actions github-actions Bot added the storage Related to "storage" package label May 26, 2026
Apply fixes suggested by `go fix` with Go 1.26:
- []byte(fmt.Sprintf(...)) → fmt.Appendf(nil, ...)
- for i := 0; i < N; i++ → for i := range N
- strings.HasSuffix + strings.TrimSuffix → strings.CutSuffix

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the apply-go-fix-modernizations branch from 9f5500e to b23c692 Compare May 26, 2026 13:02
@packit-as-a-service
Copy link
Copy Markdown

Packit jobs failed. @containers/packit-build please check.

1 similar comment
@packit-as-a-service
Copy link
Copy Markdown

Packit jobs failed. @containers/packit-build please check.

@giuseppe
Copy link
Copy Markdown
Member Author

changes already implemented in #872

one more missing, reopened:

@Luap99 @mtrmac PTAL

Copy link
Copy Markdown
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99 Luap99 merged commit 38415f0 into containers:main May 26, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

storage Related to "storage" package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants