Change storage and common version files to emulate image's#867
Open
TomSweeneyRedHat wants to merge 1 commit into
Open
Change storage and common version files to emulate image's#867TomSweeneyRedHat wants to merge 1 commit into
TomSweeneyRedHat wants to merge 1 commit into
Conversation
github-actions
Bot
added
storage
Member
Author
|
I tried searching for version to see if these changes might mess up test, but ended up with a bazillion hits from grep. Let's see what the tests turn up. |
|
Packit jobs failed. @containers/packit-build please check. |
Luap99
reviewed
May 21, 2026
Comment on lines
+6
to
+15
| // VersionMajor is for an API incompatible changes | ||
| VersionMajor = 0 | ||
| // VersionMinor is for functionality in a backwards-compatible manner | ||
| VersionMinor = 69 | ||
| // VersionPatch is for backwards-compatible bug fixes | ||
| VersionPatch = 0 | ||
|
|
||
| // VersionDev indicates development branch. Releases will be empty string. | ||
| VersionDev = "-dev" | ||
| ) |
Member
There was a problem hiding this comment.
I do not care that much but personally I find a single string much much simpler than this unnecessary splitting
Contributor
There was a problem hiding this comment.
As a general matter I dislike strings and especially string parsing, so providing numeric constants (which don’t take any runtime space) is nice.
[Running Sprintf at runtime, on every startup, is a bit less nice, but definitely not worth over-engineering to avoid.]
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/moveversions
branch
2 times, most recently
from
2df0dcf to
3a14eb1
Compare
Change the version file for c/common and c/storage to emulate the version file that is in c/image. This updates version/version.go in c/common, and moves the VERSION file in c/storage to version/version.go. Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/moveversions
branch
from
3a14eb1 to
968ac67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the version file for c/common and c/storage to emulate the version file that is in c/image. This updates version/version.go in c/common, and moves the VERSION file in c/storage to version/version.go.