common: add nolintlint, fix issues#863
Draft
kolyshkin wants to merge 1 commit into
Draft
Conversation
Fix issued found by nolintlint (mostly removal of nolint annotation).
Explain what or why we're suppressing a warning for a few cases.
Unfortunately, enabling nolintlint itself in CI results in bogus
warnings like these:
> Error: /home/runner/work/container-libs/container-libs/common/libimage/manifests/manifests.go:960:83: directive `//nolint:staticcheck // suppress "lockfile.Locker is deprecated".` is unused for linter "staticcheck" (nolintlint)
> func LockerForImage(store storage.Store, image string) (lockfile.Locker, error) { //nolint:staticcheck // suppress "lockfile.Locker is deprecated".
> ^
> Error: /home/runner/work/container-libs/container-libs/common/pkg/formats/templates.go:23:29: directive `//nolint:staticcheck` is unused for linter "staticcheck" (nolintlint)
> "title": strings.Title, //nolint:staticcheck
> ^
> Error: /home/runner/work/container-libs/container-libs/common/pkg/report/template.go:51:29: directive `//nolint:staticcheck` is unused for linter "staticcheck" (nolintlint)
> "title": strings.Title, //nolint:staticcheck
> ^
so let's keep it off the list of enabled linters.
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issued found by nolintlint (mostly removal of nolint annotation). Explain what or why we're suppressing a warning for a few cases.