fix(secrets): allow deletion of tracked secrets which no longer exist #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting a secret, it's possible the underlying driver no longer holds that secret, in which case an ErrNoSuchSecret error is thrown. In previous versions, this would force the secrets manager to keep a reference to that non-existing secret. Fixes containers/podman#27666 Signed-off-by: Samuel Gunter <sgunter@utexas.edu>
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Dec 16, 2025
|
✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6604 |
Honny1
reviewed
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a secret, it's possible the underlying driver no longer holds that secret, in which case an ErrNoSuchSecret error is thrown. In previous versions, this would force the secrets manager to keep a reference to that non-existing secret.
Fixes containers/podman#27666
Signed-off-by: Samuel Gunter sgunter@utexas.edu