Test validation #537
Closed
Test validation #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default helper binary directory on Windows was hardcoded. However the new user-scope installer deploys the binaries on a distinct directory. As a consequence `podman machine start` fails because gvproxy/winssh-proxy cannot be found. This problem affects Hyper-V, not WSL. To fix the problem we are using $BINDIR that is used by the function FindHelperBinaries to look in the directory where podman is located. Fixes containers/podman#27603 Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
…es-cp [podman-5.7] Use $BINDIR as the default helper binary directory on Windows
When using http proxy vars in the engine section they can still get leaked because http_proxy defaults to true. Fixes: https://issues.redhat.com/browse/RHEL-127541 Signed-off-by: Paul Holzinger <pholzing@redhat.com> (cherry picked from commit d205608) Signed-off-by: Paul Holzinger <pholzing@redhat.com>
[podman-5.7] common: clarify containers.conf doc for env
Bump common to v0.66.1 in preparation for Podman v5.7 Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Merge common/v0.66.1 tag into main so the go module resolver can update newer digest instead of thinking v0.66.1 is newer. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing a hypothesis for #533 .