bridge: add group_fwd_mask support for multicast forwarding (PTP)#1247
Open
VaishnavSreekumar wants to merge 1 commit intocontainernetworking:mainfrom
Open
bridge: add group_fwd_mask support for multicast forwarding (PTP)#1247VaishnavSreekumar wants to merge 1 commit intocontainernetworking:mainfrom
VaishnavSreekumar wants to merge 1 commit intocontainernetworking:mainfrom
Conversation
02d0508 to
93b8244
Compare
Signed-off-by: Vaishnav Sreekumar <vaishnavsreekumar301@gmail.com>
93b8244 to
7fc3cd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for configuring the group_fwd_mask attribute in the bridge CNI plugin. This allows the Linux bridge to forward specific link-local multicast frames (e.g., LLDP, PTP, or LACP) that are typically dropped by default.
Why is this needed?
Currently, the Linux kernel allows overriding default bridge behavior via /sys/class/net//bridge/group_fwd_mask, but the CNI bridge plugin lacks an interface to expose this configuration. This is a blocker for high-precision networking environments, specifically:
PTP (IEEE 1588): Used for sub-microsecond clock synchronization.
Telecom Profiles: Environments utilizing G.8275.1 that require specific multicast forwarding.
Changes
Schema Update: Added GroupFwdMask as an optional integer field to the NetConf struct.
Sysfs Integration: Implemented logic to write the user-defined mask to the bridge's sysfs path during setup.
Validation: Included checks to ensure the value is only applied when explicitly set, maintaining default kernel behavior otherwise.
Proposed Configuration
Users can now specify the mask in their CNI configuration file:
JSON
Technical Details
Backward Compatibility: Fully backward compatible; if the field is omitted, no changes are made to the bridge mask.
Target Version: Intended for integration into upcoming Kubernetes network driver releases.
Testing Done
Verified that the group_fwd_mask file in /sys is correctly updated when the CNI is invoked.
Confirmed that PTP traffic (multicast MAC 01-80-C2-00-00-0E) is forwarded when the mask is set appropriately.
Release note