Skip to content

fix: shared IPC ns when setting shareable #4718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weiyuhang2011 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: shared IPC ns when setting shareable #4718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9824e6
style: format code on container_run_linux tests
weiyuhang2011 Jan 24, 2026
6ae3e1d
fix: shared IPC ns when setting shareable
weiyuhang2011 Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 90 additions & 10 deletions cmd/nerdctl/container/container_run_linux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ func TestRunIpcHost(t *testing.T) {
base := testutil.NewBase(t)
testFilePath := filepath.Join("/dev/shm",
fmt.Sprintf("%s-%d-%s", testutil.Identifier(t), os.Geteuid(), base.Target))
err := os.WriteFile(testFilePath, []byte(""), 0644)
err := os.WriteFile(testFilePath, []byte(""), 0o644)
assert.NilError(base.T, err)
defer os.Remove(testFilePath)

Expand All @@ -203,7 +203,7 @@ func TestRunAddHost(t *testing.T) {
var found bool
sc := bufio.NewScanner(bytes.NewBufferString(stdout))
for sc.Scan() {
//removing spaces and tabs separating items
// removing spaces and tabs separating items
line := strings.ReplaceAll(sc.Text(), " ", "")
line = strings.ReplaceAll(line, "\t", "")
if strings.Contains(line, "10.0.0.1testing.example.com") {
Expand All @@ -219,7 +219,7 @@ func TestRunAddHost(t *testing.T) {
var found int
sc := bufio.NewScanner(bytes.NewBufferString(stdout))
for sc.Scan() {
//removing spaces and tabs separating items
// removing spaces and tabs separating items
line := strings.ReplaceAll(sc.Text(), " ", "")
line = strings.ReplaceAll(line, "\t", "")
if strutil.InStringSlice([]string{"10.0.0.1test", "10.0.0.1test1"}, line) {
Expand Down Expand Up @@ -252,7 +252,7 @@ func TestRunAddHostWithCustomHostGatewayIP(t *testing.T) {
var found bool
sc := bufio.NewScanner(bytes.NewBufferString(stdout))
for sc.Scan() {
//removing spaces and tabs separating items
// removing spaces and tabs separating items
line := strings.ReplaceAll(sc.Text(), " ", "")
line = strings.ReplaceAll(line, "\t", "")
if strings.Contains(line, "192.168.5.2test") {
Expand Down Expand Up @@ -449,7 +449,7 @@ func TestRunSigProxy(t *testing.T) {
func TestRunWithFluentdLogDriver(t *testing.T) {
base := testutil.NewBase(t)
tempDirectory := t.TempDir()
err := os.Chmod(tempDirectory, 0777)
err := os.Chmod(tempDirectory, 0o777)
assert.NilError(t, err)

containerName := testutil.Identifier(t)
Expand Down Expand Up @@ -478,7 +478,7 @@ func TestRunWithFluentdLogDriver(t *testing.T) {
func TestRunWithFluentdLogDriverWithLogOpt(t *testing.T) {
base := testutil.NewBase(t)
tempDirectory := t.TempDir()
err := os.Chmod(tempDirectory, 0777)
err := os.Chmod(tempDirectory, 0o777)
assert.NilError(t, err)

containerName := testutil.Identifier(t)
Expand Down Expand Up @@ -510,7 +510,7 @@ func TestRunWithOOMScoreAdj(t *testing.T) {
}
t.Parallel()
base := testutil.NewBase(t)
var score = "-42"
score := "-42"

base.Cmd("run", "--rm", "--oom-score-adj", score, testutil.AlpineImage, "cat", "/proc/self/oom_score_adj").AssertOutContains(score)
}
Expand Down Expand Up @@ -694,7 +694,7 @@ func TestRunDeviceCDIWithNerdctlConfig(t *testing.T) {
tomlPath := filepath.Join(t.TempDir(), "nerdctl.toml")
err := os.WriteFile(tomlPath, []byte(fmt.Sprintf(`
cdi_spec_dirs = ["%s"]
`, cdiSpecDir)), 0400)
`, cdiSpecDir)), 0o400)
assert.NilError(t, err)

base := testutil.NewBase(t)
Expand All @@ -717,9 +717,89 @@ devices:
- FOO=injected
`

err := os.MkdirAll(cdiSpecDir, 0700)
err := os.MkdirAll(cdiSpecDir, 0o700)
assert.NilError(t, err)
cdiSpecPath := filepath.Join(cdiSpecDir, "vendor1.yaml")
err = os.WriteFile(cdiSpecPath, []byte(testCDIVendor1), 0400)
err = os.WriteFile(cdiSpecPath, []byte(testCDIVendor1), 0o400)
assert.NilError(t, err)
}

func TestSharedIpcSetup(t *testing.T) {
nerdtest.Setup()
testCase := &test.Case{
Require: require.Not(require.Windows),
Setup: func(data test.Data, helpers test.Helpers) {
data.Labels().Set("container1", data.Identifier("container1"))
helpers.Ensure("run", "-d", "--name", data.Identifier("container1"), "--ipc=shareable",
testutil.CommonImage, "sleep", "inf")
nerdtest.EnsureContainerStarted(helpers, data.Identifier("container1"))
},
Cleanup: func(data test.Data, helpers test.Helpers) {
helpers.Anyhow("rm", "-f", data.Identifier("container1"))
},
SubTests: []*test.Case{
{
Description: "Test ipc is shared",
NoParallel: true, // The validation involves starting of the main container: container1
Cleanup: func(data test.Data, helpers test.Helpers) {
helpers.Anyhow("rm", "-f", data.Identifier("container2"))
},
Setup: func(data test.Data, helpers test.Helpers) {
helpers.Ensure(
"run", "-d", "--name", data.Identifier("container2"),
"--ipc=container:"+data.Labels().Get("container1"),
testutil.NginxAlpineImage)
data.Labels().Set("container2", data.Identifier("container2"))
nerdtest.EnsureContainerStarted(helpers, data.Identifier("container2"))
},
SubTests: []*test.Case{
{
NoParallel: true,
Description: "Test ipc is shared",
Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
return helpers.Command("exec", data.Labels().Get("container2"), "readlink", "/proc/1/ns/ipc")
},
Expected: func(data test.Data, helpers test.Helpers) *test.Expected {
return &test.Expected{
ExitCode: 0,
Output: expect.All(
func(stdout string, t tig.T) {
container1IPC := strings.TrimSpace(helpers.Capture("exec", data.Labels().Get("container1"), "readlink", "/proc/1/ns/ipc"))
container2IPC := strings.TrimSpace(stdout)
assert.Equal(t, container1IPC, container2IPC)
},
),
}
},
},
{
NoParallel: true,
Description: "Test ipc is shared after restart",
Setup: func(data test.Data, helpers test.Helpers) {
helpers.Ensure("restart", data.Labels().Get("container1"))
helpers.Ensure("stop", "--time=1", data.Labels().Get("container2"))
helpers.Ensure("start", data.Labels().Get("container2"))
nerdtest.EnsureContainerStarted(helpers, data.Labels().Get("container2"))
},
Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
return helpers.Command("exec", data.Labels().Get("container2"), "readlink", "/proc/1/ns/ipc")
},
Expected: func(data test.Data, helpers test.Helpers) *test.Expected {
return &test.Expected{
ExitCode: 0,
Output: expect.All(
func(stdout string, t tig.T) {
container1IPC := strings.TrimSpace(helpers.Capture("exec", data.Labels().Get("container1"), "readlink", "/proc/1/ns/ipc"))
container2IPC := strings.TrimSpace(stdout)
assert.Equal(t, container1IPC, container2IPC)
},
),
}
},
},
},
},
},
}
testCase.Run(t)
}
5 changes: 5 additions & 0 deletions pkg/ipcutil/ipcutil.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,11 @@ func GenerateIPCOpts(ctx context.Context, ipc IPC, client *containerd.Client) ([
}

opts = append(opts, withBindMountHostOtherSourceIPC(*targetConIPC.HostShmPath))
ns := specs.LinuxNamespace{
Type: specs.IPCNamespace,
Path: fmt.Sprintf("/proc/%d/ns/ipc", task.Pid()),
}
opts = append(opts, oci.WithLinuxNamespace(ns))
}

return opts, nil
Expand Down
Loading