Use os.Root for copy operations in vminitd#168
Open
dmcgowan wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the container filesystem transfer logic in vminitd to anchor copy/export/import operations using os.Root, aiming to prevent path traversal and symlink-escape issues by avoiding destination-path resolution.
Changes:
- Introduces
rootReland migrateswritePathto useos.OpenRoot+root.FS()walking and*os.Rootfile operations. - Migrates
readPathextraction to enforce destination boundaries via a sub-*os.Root, removing prior lexical prefix checks. - Adds comprehensive tests covering tar path traversal, symlink/hardlink attacks, and round-trip export/import behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| internal/transfer/containerfs.go | Switches export/import implementation to *os.Root-anchored operations and adds rootRel helper. |
| internal/transfer/containerfs_test.go | Adds security- and correctness-focused tests for export/import behavior (symlinks, traversal, round-trips). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Derek McGowan <derek@mcg.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the transfer in vminitd to use os.Root rather than path resolution into the destination path