fix(plpgsql-deparser): fix failing fixtures - EXCEPTION blocks, schema qualification, implicit variables

[pyramation]

fix(plpgsql-deparser): fix EXCEPTION blocks, schema qualification, implicit variables

Summary

This PR fixes 13 of the 16 known failing fixtures in the plpgsql-deparser round-trip test suite. The main fixes are:

1. EXCEPTION block handling: The deparser was not outputting EXCEPTION blocks because it checked for block.exceptions.exc_list directly, but the parser wraps exception blocks in a PLpgSQL_exception_block wrapper. Now handles both formats.

2. Schema qualification preservation: Modified deparseType() to preserve schema qualification for %rowtype and %type references (e.g., pg_catalog.pg_class%rowtype[] no longer gets incorrectly stripped).

3. Implicit variables filtering: Added sqlstate and sqlerrm to the list of implicit variables filtered from DECLARE sections (PostgreSQL adds these automatically for exception handling).

4. Test utils improvement: Added varno to the list of properties ignored during AST comparison, since variable numbers change when implicit variables are filtered out.

Results: 187 of 190 fixtures now pass (up from 174). Only 3 fixtures remain failing:

• plpgsql_varprops-13.sql (nested DECLARE inside FOR loop)
• plpgsql_transaction-17.sql (CURSOR FOR loop with EXCEPTION block)
• plpgsql_control-15.sql (labeled block with EXIT statement)

Review & Testing Checklist for Human

• Verify EXCEPTION block output is correct: Check the snapshot diffs - EXCEPTION handlers are now being output. Verify the WHEN ... THEN clauses and their actions are semantically correct.
• Test schema qualification edge cases: The fix uses typname.includes('%rowtype') - verify this doesn't have false positives/negatives for unusual type names.
• Verify varno filtering doesn't mask real bugs: The test-utils now ignores varno values during comparison. Confirm this is safe and doesn't hide semantic differences.
• Run a manual round-trip test: Parse a real PL/pgSQL function with EXCEPTION blocks, deparse it, and verify the output is valid SQL that PostgreSQL accepts.

Notes

• The as any type cast on line 582 and 588 of plpgsql-deparser.ts is used to handle the wrapped exception block format - this could be improved with proper typing.
• The 3 remaining failing fixtures appear to have different root causes (loop variable scope, cursor handling, labeled blocks) that would require separate fixes.

Link to Devin run: https://app.devin.ai/sessions/8e1c971e9b194cd9a7dda034c89bd74b
Requested by: @pyramation

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring