-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: rename db-meta packages to metaschema, add services package #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename db-meta-modules to metaschema-modules - Rename db-meta-schema to metaschema-schema - Rename schema names: collections_public/private -> metaschema_public/private - Rename schema names: meta_public/private -> metaschema_modules_public/services_public/services_private - Add new services package for module registration and service configuration Upstreamed from constructive-io/constructive-db
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Update metaschema-schema tests to only test metaschema_public tables - Create services package tests for integration testing with services_public tables - Remove old snapshot file that's no longer needed
3 tasks
Services-dependent tests (complete workflow, domain registration) are already in the services package. This avoids CI failures since packages are tested in isolation.
- Update metaschema-modules/Makefile: EXTENSION and DATA now use metaschema-modules--0.15.5.sql - Update metaschema-schema/Makefile: EXTENSION and DATA now use metaschema-schema--0.15.5.sql - Add @pgpm/services dependency to metaschema-modules/package.json (required by .control file) - Update README.md: rename db-meta-* to metaschema-* in package list, add @pgpm/services - Update MODULES.md: fix package paths from packages/meta/db-meta-* to packages/metaschema-* - Update metaschema-schema/README.md: rename all references from db-meta-schema to metaschema-schema - Update metaschema-modules/README.md: rename all references from db-meta-modules to metaschema-modules - Update inflection/README.md: rename db-meta-schema reference to metaschema-schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: rename db-meta packages to metaschema, add services package
Summary
Upstreams schema renaming changes from constructive-io/constructive-db to this repository. This is a breaking change that renames core packages and PostgreSQL schemas:
Package renames:
db-meta-modules→metaschema-modulesdb-meta-schema→metaschema-schemaSchema renames:
collections_public/collections_private→metaschema_public/metaschema_privatemeta_public/meta_private→metaschema_modules_public/services_public/services_privateNew package:
services- Contains tables for APIs, sites, domains, apps, and site configuration (metadata, modules, themes)Updates since last revision
descriptioncolumn; table/field usenamenottable_name/field_name)metaschema_modules_publicschema instead ofservices_publicservicespackage since CI runs packages in isolation. Themetaschema-schemapackage has a simple database creation test only.EXTENSIONandDATAin both metaschema-modules and metaschema-schema Makefiles to use new names and correct SQL version (0.15.5 instead of 0.15.3)@pgpm/servicesto metaschema-modules/package.json (required by .control file)Review & Testing Checklist for Human
sql/metaschema-modules--0.15.5.sqlandsql/metaschema-schema--0.15.5.sqlexist in their respective package directoriesmetaschema_publicandservices_publictables is now only in theservicespackage - confirm this provides adequate coverage@pgpm/db-meta-modules,@pgpm/db-meta-schema) will need updatesRecommended test plan:
pnpm installandpnpm testin the repomake installin metaschema-modules and metaschema-schema packages to verify Makefiles workNotes
This PR was created by copying the
pgpm-modules/folder from constructive-db which had already been modified with these renames. The changes were originally made in commits starting from the "vendor pgpm-modules" commit through the metaschema rename commits.Link to Devin run: https://app.devin.ai/sessions/e6eaf10a10804d28bf10e39b7dbe6698
Requested by: Dan Lynch (pyramation@gmail.com) / @pyramation