Feat/remove dotenv #447
Merged
Feat/remove dotenv #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove 'dotenv/config' import from server.ts - Refactor create-bucket.ts to use getEnvOptions() from @constructive-io/graphql-env - Remove dotenv dependency from graphql/server/package.json - Add AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY aliases to pgpm/env/src/env.ts for compatibility Co-Authored-By: Dan Lynch <pyramation@gmail.com>
Development environment variables should be set via actual environment variables or config files (pgpm.config.js/pgpm.json), not committed .env files. Co-Authored-By: Dan Lynch <pyramation@gmail.com>
Prevent future .env files from being committed to the repository. Co-Authored-By: Dan Lynch <pyramation@gmail.com>
Co-Authored-By: Dan Lynch <pyramation@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.