fix: ensure roles and connections are always resolved from defaults i… #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n getConnEnvOptions - Fix root cause: getConnEnvOptions now explicitly merges defaults for roles and connections to prevent undefined values even if config/env explicitly sets them to undefined - Add defensive validation in SQL generators (generateCreateBaseRolesSQL, generateCreateUserSQL, generateCreateTestUsersSQL, generateRemoveUserSQL) to throw clear errors if roles is undefined - Add comprehensive tests for roles SQL generators input validation - Add tests for getConnEnvOptions to verify defaults are always resolved Fixes TypeError: Cannot read properties of undefined (reading 'anonymous') in admin-users bootstrap Co-Authored-By: Dan Lynch <pyramation@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n getConnEnvOptions
Fixes TypeError: Cannot read properties of undefined (reading 'anonymous') in admin-users bootstrap