fix: ensure roles and connections are always resolved from defaults in getConnEnvOptions #441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
TypeError: Cannot read properties of undefined (reading 'anonymous')when runningpgpm admin-users bootstrap.The root cause was that
getConnEnvOptions()could returnundefinedforrolesandconnectionsif a config file or environment explicitly set these toundefined, bypassing the deepmerge defaults. This PR:getConnEnvOptionsto explicitly spread defaults forrolesandconnections, ensuring they're always resolvedReview & Testing Checklist for Human
getConnEnvOptionschange doesn't break existing config overrides - the tests show partial overrides still work, but worth confirming with your actual config filespgpm admin-users bootstrap --yesworks with the fixpgpm admin-users addandpgpm admin-users removestill work (they use the same SQL generators)Recommended test plan:
Notes
db.roles: undefined, version mismatch in global install, etc.). This fix ensures defaults are always applied regardless.jest.config.jstopgpm/envpackage to enable running the new testsLink to Devin run: https://app.devin.ai/sessions/3a8e8acb237e4b08bc1878defcf041f0
Requested by: Dan Lynch (@pyramation)