-
Notifications
You must be signed in to change notification settings - Fork 47
refactor(repo): move all crates into crates folder #1268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
77e21bc to
4000d02
Compare
4000d02 to
1edaed6
Compare
karlem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The Docker image build is failing.
- There are still references to "fendermint" in a few places in the codebase. The PR description should mention that we are renaming "fendermint" to "client."
- I would abstain from committing the generated bindings into Git and instead have them generated as part of the Cargo build process or something similar.
1edaed6 to
6e28ee7
Compare
860bf6f to
7678f46
Compare
I cannot rename all of fendermint right now, since we still produce a binary named |
|
I think "client" is ambiguous because it's a relative term -- "a client of what?" Would prefer "node" |
karlem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drahnr I agree with the rename from client to node, but there are still some references to client left. I suggest searching for client/.
85ac7cb to
f0c5edf
Compare
karlem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGT, but the CI needs to be fixed first. Build is failing.
a66df56 to
4a6461d
Compare
29ea3cd to
45b5148
Compare
65068e5 to
9237e67
Compare
Moves all rust crates into a joint crates folder,
bindingis moved out fromcontractsintocratesascontract-bindings,fendermintbecomesclientThis change is