forked from vectordotdev/vector
-
Notifications
You must be signed in to change notification settings - Fork 0
enhancement(topology): add per-sink authoritative acknowledgement control #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
connoryy
wants to merge
21
commits into
master
Choose a base branch
from
connor/upstream-authoritative-acks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
edc1285
feat(sinks): add per-sink `authoritative` acknowledgement field
connoryy 0247ac2
feat(sinks): implement RFC 6517 authoritative sink semantics
connoryy f50aa97
Move finalizer stripping from sink-level to fan-out-level
connoryy df3ec28
Address review feedback on authoritative sink acks
connoryy 31828f7
test: add compute_authoritative_components and backwards compat tests
connoryy ad83b95
test(topology): add e2e test proving authoritative sink controls ack …
connoryy fa18d76
fix: add authors to changelog fragment
connoryy c11c9dd
style: fix formatting
connoryy ff4754a
chore(ci): make nightly S3 verify resilient to CDN staleness (#25259)
pront 6f38579
fix(vrl): restore stdlib functions in CLI and playground (#25310)
pront 23016ad
chore(internal docs): fix release issue templates (#25318)
pront 96ad9ed
fix(website): improve docs search ranking for component pages (#25319)
thomasqueirozb ce6ca43
chore(codecs): centralize `events_dropped` emission for batch encodin…
pront d6cdf03
fix(releasing): enable codecs-parquet in all release feature sets (#2…
pront 233a35c
fix(ci): correct cross-build artifact name and path (#25282)
thomasqueirozb d1fa4b0
Merge branch 'master' into connor/upstream-authoritative-acks
connoryy d47d3e6
fix: clippy map_unwrap_or in fanout replace handler
connoryy 13da597
Merge branch 'master' of github.com:vectordotdev/vector into connor/u…
connoryy 24e9db5
Merge remote-tracking branch 'connoryy/connor/upstream-authoritative-…
connoryy f609fea
fix(topology): require enabled for authoritative sinks in BFS
connoryy 6257497
fix(topology): preserve legacy ack behavior for pipelines without aut…
connoryy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Sinks using batch encoding (Parquet, Arrow IPC) now consistently emit `ComponentEventsDropped` for every encode failure path. Previously some `build_record_batch` failures (notably type mismatches) dropped events silently. A new `EncoderRecordBatchError` internal event also reports `component_errors_total` with `error_code="arrow_json_decode"` or `"arrow_record_batch_creation"` at `stage="sending"` for granular alerting. | ||
|
|
||
| authors: pront |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Restored the full VRL stdlib, including `get_env_var`, in the standalone VRL CLI and web playground by default. | ||
| authors: pront |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Parquet encoding in the `aws_s3` sink (`batch_encoding`) now works out of the box in the official release binaries. Previously it required compiling Vector from source with the `codecs-parquet` feature. | ||
|
|
||
| authors: pront |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Added `authoritative` field to sink acknowledgements configuration. The field defaults to `false`; the feature only activates when at least one sink explicitly sets `authoritative: true`. When active, only **authoritative** sinks block source acknowledgements -- non-authoritative sinks have their event finalizers stripped so the source can acknowledge events as soon as all authoritative sinks have processed them. This prevents non-critical sinks (console, metrics, etc.) from blocking acknowledgement of critical sinks. When no sink sets `authoritative: true`, there is zero behavioral change from previous versions. | ||
|
|
||
| authors: connoryy | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.