Skip to content

Allow standard sync command to install all packages including OTel#197

Merged
anuraaga merged 3 commits intoconnectrpc:mainfrom
anuraaga:sync-all-packages
Apr 3, 2026
Merged

Allow standard sync command to install all packages including OTel#197
anuraaga merged 3 commits intoconnectrpc:mainfrom
anuraaga:sync-all-packages

Conversation

@anuraaga
Copy link
Copy Markdown
Collaborator

@anuraaga anuraaga commented Mar 30, 2026

With connectrpc-otel, we have dependencies that aren't installed by default without this, resulting in red lines in IDE on first load. If we move those to the root, a standard sync command allows the entire repo's code to be worked on without extra steps / options.

Best would be if we could configure this behavior as a default in pyproject.toml but it's still open for a long time

astral-sh/uv#5737
astral-sh/uv#9755

Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
@anuraaga anuraaga requested a review from a team March 30, 2026 01:59
@anuraaga
Copy link
Copy Markdown
Collaborator Author

@stefanvanburen Thanks! Just to confirm for this

An alternative to this would be making the pyproject's somewhat confusing by moving any subproject dependencies to the top level as needed

So do you think it's better to update the readme like this vs tweak dev dependencies in the root? Just curious how people feel on that.

@stefanvanburen
Copy link
Copy Markdown
Member

@anuraaga yeah, it's a bit of an unhappy situation either way, as you mentioned.

Thinking a little more, it's probably annoying to need to remember to provide the flag all the time to sync all the deps; I'd probably rather have a commented section of the pyproject.toml w/ the sub-package deps (& maybe a link to the upstream uv issue)?

@anuraaga anuraaga changed the title Recommend sync all-packages by default Allow standard sync command to install all packages including OTel Apr 2, 2026
@anuraaga anuraaga requested a review from stefanvanburen April 2, 2026 02:44
@anuraaga
Copy link
Copy Markdown
Collaborator Author

anuraaga commented Apr 2, 2026

Thanks @stefanvanburen - I have changed to moving the dev dependencies to the root.

Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
@anuraaga anuraaga force-pushed the sync-all-packages branch from ed3130c to d5833fd Compare April 2, 2026 02:46
@anuraaga anuraaga merged commit 92a3b0a into connectrpc:main Apr 3, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants