Allow standard sync command to install all packages including OTel#197
Merged
anuraaga merged 3 commits intoconnectrpc:mainfrom Apr 3, 2026
Merged
Allow standard sync command to install all packages including OTel#197anuraaga merged 3 commits intoconnectrpc:mainfrom
anuraaga merged 3 commits intoconnectrpc:mainfrom
Conversation
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
stefanvanburen
approved these changes
Mar 30, 2026
Collaborator
Author
|
@stefanvanburen Thanks! Just to confirm for this
So do you think it's better to update the readme like this vs tweak dev dependencies in the root? Just curious how people feel on that. |
Member
|
@anuraaga yeah, it's a bit of an unhappy situation either way, as you mentioned. Thinking a little more, it's probably annoying to need to remember to provide the flag all the time to sync all the deps; I'd probably rather have a commented section of the pyproject.toml w/ the sub-package deps (& maybe a link to the upstream uv issue)? |
…nto sync-all-packages
Collaborator
Author
|
Thanks @stefanvanburen - I have changed to moving the dev dependencies to the root. |
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
ed3130c to
d5833fd
Compare
stefanvanburen
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
connectrpc-otel, we have dependencies that aren't installed by default without this, resulting in red lines in IDE on first load. If we move those to the root, a standard sync command allows the entire repo's code to be worked on without extra steps / options.Best would be if we could configure this behavior as a default in pyproject.toml but it's still open for a long time
astral-sh/uv#5737
astral-sh/uv#9755