Skip to content

Conversation

@anuraaga
Copy link
Collaborator

Referred to the Go page for context but content mostly different due to the different signatures.

=== "ASGI"

```python
class GoodbyeInterceptor:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example is very contrived, but I couldn't come up with anything much better, at least if demonstrating response overriding. I wanted to present the basic mechanism before going to metadata interceptors, which are actually going to be 90% of interceptors.

Happy to hear any thoughts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me to have it start this way — I don't have a less contrived version off-hand from using interceptors in other implementations for request replacement. As you said, it's typically metadata that's changed.

Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
Copy link
Member

@stefanvanburen stefanvanburen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

=== "ASGI"

```python
class GoodbyeInterceptor:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me to have it start this way — I don't have a less contrived version off-hand from using interceptors in other implementations for request replacement. As you said, it's typically metadata that's changed.

@anuraaga anuraaga merged commit 330263d into connectrpc:main Sep 25, 2025
17 checks passed
@anuraaga anuraaga added the documentation Improvements or additions to documentation label Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants