-
Notifications
You must be signed in to change notification settings - Fork 59
Add support for FactionsUUID #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
*not tested*
|
Um, I am confused here. |
|
FactionsUUID is a fork of the 1.6.x branch from MassiveCraft. Here's the source code: https://github.com/drtshock/Factions |
|
I'm pretty sure this error report (https://pastebin.com/zgqDHc1F) from XxDawnsusxX is due to the use of FactionsUUID (They share the same Plugin Name, since it's a fork as I said). Also because he asked if the plugin had FactionsUUID support: https://www.spigotmc.org/threads/lockettepro-uuid-support.133105/page-16#post-2423200 |
|
I will give this a shot. |
|
Appreciate your effort, but unfortunately I decide not to support FactionsUUID for now. Supporting two plugins with same plugin name and different package names... too messy. And yet I doubt the effort to maintain FactionUUID support will worth it... Also the plugin itself costs $15 and lack of API documentation... meh... |
|
@connection-lost I understand the trouble of supporting two forks of the same plugin. If my fix does work, I suggest you to add it as it's a fire-and-forget addition (FactionsUUID won't likely change anything of their API). |
not tested