fix: only log 4xx errors when debug is enabled in DebuggableExceptionMapper#691
Open
VinayakGote (Vinu2111) wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
debug=false, 4xx errors (such asRestNotFoundException) were stillbeing logged via
log.debug(...)unconditionally inDebuggableExceptionMapper.The comment in the code said "Only log other errors, including user-errors 4xx,
if debugging enabled" — but the condition was never actually checked for logging.
Fixes the behaviour described in #221.
Change
In
createResponse(), theelsebranch that logs 4xx errors has been changedto an
else ifthat checksrestConfig.getBoolean(RestConfig.DEBUG_CONFIG)before logging. 5xx errors are unaffected — they always log at ERROR level.
Before:
After:
Tests
Added
DebuggableExceptionMapperTestcovering three cases:debug=false→ no stack trace in response messagedebug=true→ stack trace included in response messagedebug=false→ always logs, no stack trace in message