Fix segfault #427
Fix segfault #427
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes segmentation faults by adding null pointer checks in the V8 object conversion code and updates version strings from release candidate to final/test versions.
- Adds null safety checks for node pointers, host strings, leader nodes, and ISR/replica arrays to prevent segfaults during broker restarts or metadata updates
- Updates version numbers from "1.8.0-rc2" to "1.8.0" or "1.8.0-test" across multiple files
- Updates librdkafka dependency version from "2.13.0-RC2" to "2.13.0"
- Adds new CI workflow blocks for building PR artifacts on Linux (glibc/musl) and macOS arm64 platforms
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/common.cc | Adds null pointer checks for node, host, leader, ISR and replica arrays to prevent segfaults |
| schemaregistry/package.json | Updates version from 1.8.0-rc2 to 1.8.0 |
| package.json | Updates version to 1.8.0-test and librdkafka dependencies to 2.13.0 |
| lib/util.js | Updates bindingVersion to 1.8.0-test |
| lib/error.js | Updates comment to reference librdkafka 2.13.0 instead of RC2 |
| .semaphore/semaphore.yml | Adds PR artifact build workflows for Linux and macOS platforms |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "name": "@confluentinc/kafka-javascript", | ||
| "version": "1.8.0-rc2", | ||
| "version": "1.8.0-test", |
There was a problem hiding this comment.
The version suffix '-test' is unconventional for production releases. Standard semantic versioning uses suffixes like '-alpha', '-beta', or '-rc' for pre-release versions. Consider using '1.8.0' for the final release or a standard pre-release identifier.
| "version": "1.8.0-test", | |
| "version": "1.8.0", |
| }; | ||
|
|
||
| util.bindingVersion = '1.8.0-rc2'; | ||
| util.bindingVersion = '1.8.0-test'; |
There was a problem hiding this comment.
The version suffix '-test' is unconventional and inconsistent with the schemaregistry package which uses '1.8.0'. These version strings should match or follow standard semantic versioning conventions.
| util.bindingVersion = '1.8.0-test'; | |
| util.bindingVersion = '1.8.0'; |
airlock-confluentinc
bot
force-pushed
the
fix-segfault
branch
from
196ea99 to
9c5db96
Compare
airlock-confluentinc
bot
force-pushed
the
fix-segfault
branch
from
9c5db96 to
4a4e155
Compare
|
No description provided.