Add jetty-alpn-*-client artifacts to dependencyManagement (7.9.x)#1008
Open
Hritwik Singhai (devhritwik) wants to merge 1 commit into
Open
Add jetty-alpn-*-client artifacts to dependencyManagement (7.9.x)#1008Hritwik Singhai (devhritwik) wants to merge 1 commit into
Hritwik Singhai (devhritwik) wants to merge 1 commit into
Conversation
Mirrors the same fix on common/7.8.x. PR #990 (9c2d2ea) replaced jetty-bom in dependencyManagement with explicit per-artifact entries, but only included the three *-server variants (jetty-alpn-conscrypt-server, jetty-alpn-java-server, jetty-alpn-server). The change landed on common/7.8.x via 8bc8dba on 2026-05-14 and propagated to common/7.9.x via the recent 7.8.x->7.9.x merge (a9c100d). The mirror *-client variants, previously transitively managed by jetty-bom, were missed. This broke any downstream consumer that depended on these artifacts without a version. Concretely, the cp_packaging "Build rest-utils jar" job started failing on rest-utils/7.9.x (https://semaphore.ci.confluent.io/jobs/a764a728-b344-4d00-95e1-d19ba46b9e3d) with: 'dependencies.dependency.version' for org.eclipse.jetty:jetty-alpn-java-client:jar is missing. @ rest-utils/fips-tests/pom.xml line 50, column 21 rest-utils worked around this in PR #705 (7.9.x) by declaring the version explicitly, but the proper fix lives here: restore the *-client triple to dependencyManagement so all downstream consumers (current and future) get the right version without each having to declare it themselves. Adds, mirroring the *-server set: - jetty-alpn-client - jetty-alpn-conscrypt-client - jetty-alpn-java-client All resolve to ${jetty.version}, identical to what jetty-bom provided before. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors Add jetty-alpn-*-client artifacts to dependencyManagement (7.8.x) #1007 (7.8.x). PR replace jetty-bom with individual dependency definitions #990 (`9c2d2eaa22`) replaced `jetty-bom` in `dependencyManagement` with explicit per-artifact entries, but only included the three `-server` variants. The regression landed on `common/7.8.x` via `8bc8dba5f1` on 2026-05-14 and propagated to `common/7.9.x` via the recent 7.8.x→7.9.x merge (`a9c100ddbc`). The mirror `-client` variants, previously transitively managed by `jetty-bom`, were missed.
This broke any downstream consumer that depended on these artifacts without a version. Concretely, the cp_packaging Build rest-utils jar job started failing on `rest-utils/7.9.x` (https://semaphore.ci.confluent.io/jobs/a764a728-b344-4d00-95e1-d19ba46b9e3d):
rest-utils worked around this with fips-tests: add explicit jetty-alpn-java-client version after common dropped jetty-bom (7.9.x) rest-utils#705 (7.9.x) by declaring `${jetty.version}` explicitly, but the proper fix lives here: restore the `*-client` triple to `dependencyManagement` so all downstream consumers (current and future) get the right version without each having to declare it themselves.
Adds, mirroring the `*-server` set already in place:
All resolve to `${jetty.version}`, identical to what `jetty-bom` provided before.
Test plan
Related
🤖 Generated with Claude Code