-
Notifications
You must be signed in to change notification settings - Fork 33
Adds company management endpoints #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Introduces endpoints for creating, retrieving, and managing company documents. Updates the SDK version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @fcarrero, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly expands the API's capabilities by introducing a complete set of endpoints for managing companies. This includes the ability to create new company entities and handle all aspects of their associated documents, from uploading and updating to retrieving them. The changes also involve a version bump for the SDK and a refactoring of underlying data models to support these new functionalities.
Highlights
- New Company Management Endpoints: I've introduced new API endpoints under the
CompaniesApito enable comprehensive company management. This includes functionality to create new company records, retrieve lists of companies, and fetch details for a specific company. - Company Document Management: I've added robust document management capabilities for companies. You can now upload new documents, update existing ones, and retrieve a list of all documents associated with a company. This is crucial for compliance and record-keeping.
- API Version Update: The API version has been incremented from 7.0.1 to 7.0.2 across the SDK, including updates to
README.md,VERSIONfile,__init__.py,api_client.py,configuration.py,pyproject.toml, andsetup.py. - Model Refactoring and New Data Structures: Several internal models related to company fiscal information and payout destinations have been refactored and renamed to better align with the new company creation and document management flows. This includes the introduction of
CompanyDocumentRequest,CompanyDocumentResponse,CompanyResponseDocumentsInner,CreateCompanyRequest,CreateCompanyRequestBankAccountInfo,CreateCompanyRequestComercialInfo, andCreateCompanyRequestFiscalInfo. - Minor Payment Method Updates: A minor update was made to the
PaymentMethodBnplRequestmodel, changing theklarna_bnplproduct type toaplazo_bnpl. Additionally, abankfield was added to thePaymentMethodSpeiRecurrentmodel and its related documentation.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new endpoints for company management, including creation, document handling (upload, update, retrieval), and updates the API version to 7.0.2. The changes are mostly auto-generated and look good. I've found a few typos in enum values, class names, and documentation examples that should be corrected for consistency and clarity. Specifically, power_of_attonery should be power_of_attorney, and comercial should be commercial. Also, some Python examples in the documentation are syntactically incorrect.
Creates an example script demonstrating how to create an order with a one-time charge using a Buy Now, Pay Later (BNPL) payment method. This showcases the integration of the Orders API for processing BNPL transactions.
Adds endpoints for managing companies: