Skip to content

Conversation

@mar-js
Copy link

@mar-js mar-js commented Apr 28, 2025

Updated version

@mar-js mar-js self-assigned this Apr 28, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mar-js, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the package version from 7.0.0 to 7.0.1 across multiple files. The changes primarily involve updating the __version__ variable in conekta/__init__.py, bindings_version and user_agent in conekta/api_client.py, SDK Package Version in conekta/configuration.py, packageVersion and httpUserAgent in config-python.json, and the VERSION file. Additionally, the pull request introduces a plan_ids field to the CheckoutOrderTemplate, CheckoutRequest, and CheckoutResponse models, along with corresponding updates to the documentation and validation logic for allowed payment methods in CheckoutRequest.

Highlights

  • Version Update: The core purpose of this PR is to bump the package version from 7.0.0 to 7.0.1 across the project.
  • Checkout Models Enhancement: The CheckoutOrderTemplate, CheckoutRequest, and CheckoutResponse models have been updated to include a plan_ids field, allowing association of plan IDs with checkout orders and requests.
  • Payment Method Validation: Added validation for allowed payment methods in CheckoutRequest to ensure that only valid payment methods are used.

Changelog

Click here to see the changelog
  • README.md
    • Updated package version from 7.0.0 to 7.0.1.
  • VERSION
    • Updated version from 7.0.0 to 7.0.1.
  • conekta/init.py
    • Updated __version__ from 7.0.0 to 7.0.1.
  • conekta/api_client.py
    • Updated bindings_version from 7.0.0 to 7.0.1.
    • Updated user_agent from 'Conekta/v2 PythonBindings/7.0.0' to 'Conekta/v2 PythonBindings/7.0.1'.
  • conekta/configuration.py
    • Updated SDK Package Version from 7.0.0 to 7.0.1 in debug report.
  • conekta/models/checkout_order_template.py
    • Added plan_ids field to the CheckoutOrderTemplate model.
    • Updated __properties to include plan_ids.
    • Updated from_dict method to include plan_ids.
  • conekta/models/checkout_request.py
    • Added plan_ids field to the CheckoutRequest model.
    • Updated __properties to include plan_ids.
    • Added validation for allowed_payment_methods.
    • Updated from_dict method to include plan_ids.
  • conekta/models/checkout_response.py
    • Added plan_ids field to the CheckoutResponse model.
    • Updated __properties to include plan_ids.
    • Updated from_dict method to include plan_ids.
  • config-python.json
    • Updated packageVersion from 7.0.0 to 7.0.1.
    • Updated httpUserAgent from 'Conekta/v2 PythonBindings/7.0.0' to 'Conekta/v2 PythonBindings/7.0.1'.
  • docs/CheckoutOrderTemplate.md
    • Added documentation for the plan_ids field.
  • docs/CheckoutRequest.md
    • Added documentation for the plan_ids field.
    • Updated documentation for allowed_payment_methods.
  • docs/CheckoutResponse.md
    • Added documentation for the plan_ids field.
  • pyproject.toml
    • Updated version from 7.0.0 to 7.0.1.
  • setup.py
    • Updated version from 7.0.0 to 7.0.1.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A version increments,
Small changes, big impact felt,
Code evolves on.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the package version from 7.0.0 to 7.0.1 across multiple files. The changes appear to be straightforward version updates. However, a closer look reveals opportunities to improve the consistency and maintainability of the versioning process.

Summary of Findings

  • Inconsistent Version Updates: The version update is performed in multiple files (README.md, VERSION, init.py, api_client.py, configuration.py, config-python.json, pyproject.toml, setup.py). This manual process is prone to errors and inconsistencies. Consider using a single source of truth for the version and updating it automatically across all files.
  • Missing Tests: There are no tests included in this pull request. It would be ideal to have a test that verifies the version number is correct, to prevent regressions.
  • Documentation Updates: The documentation updates in CheckoutOrderTemplate.md, CheckoutRequest.md, and CheckoutResponse.md add descriptions for the plan_ids field. Ensure that these descriptions are clear, concise, and accurately reflect the purpose and usage of the field.

Merge Readiness

The pull request updates the package version across multiple files. While the changes are straightforward, the manual process is prone to errors and inconsistencies. I recommend addressing the findings related to version consistency and adding a test to verify the version number before merging. I am unable to approve this pull request, and recommend that others review and approve this code before merging.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the SDK version from 7.0.0 to 7.0.1 and adds the new "plan_ids" field to both the documentation and the model classes.

  • Updated version numbers in setup.py, pyproject.toml, configuration, api_client, init.py, and README.md.
  • Added "plan_ids" to CheckoutResponse, CheckoutRequest, and CheckoutOrderTemplate along with corresponding documentation updates.

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.

File Description
setup.py, pyproject.toml Version bump from 7.0.0 to 7.0.1.
docs/*.md Added new "plan_ids" documentation lines and updated description for allowed_payment_methods.
conekta/models/* Added "plan_ids" field to the CheckoutResponse, CheckoutRequest, and CheckoutOrderTemplate models.
conekta/configuration.py, api_client.py, init.py, README.md Updated version numbers to 7.0.1.
Files not reviewed (2)
  • VERSION: Language not supported
  • config-python.json: Language not supported

…t.md to clarify its use in different payment types
@mar-js mar-js merged commit 2964f55 into main Apr 30, 2025
11 checks passed
@mar-js mar-js deleted the bump/v7.0.1 branch April 30, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants