-
-
Notifications
You must be signed in to change notification settings - Fork 308
Start a how-to on populating dependencies #2704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Michał Górny <mgorny@quansight.com>
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
|
@jaimergp, I'm not sure if this is what you was thinking of. I've ended up pretty much sharing my experience from years of bumping packages, but perhaps it's too verbose. |
h-vetinari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't read everything in depth yet, but I like this a lot!
| - Look through upstream documentation. Many projects include sections on building, with detailed | ||
| explanations where to find dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be more explicit here on the 99% path (for python packages at least), which is:
- look in upstream
setup.py - look in upstream
pyproject.toml(perhaps this could be bumped to top spot nowadays) - look for
requirements*.txtfiles - upstream README
| - As a last resort, in some cases you can resort to checking the source code. There are tools that | ||
| can help with this, e.g. [findimports](https://pypi.org/project/findimports/) for Python. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd definitely recommend looking at the source code before some of these steps
| When building v1 recipes, `rattler-build` outputs finalized run dependencies, along with their | ||
| sources, e.g.: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should briefly mention here that "RE" stands for "run export". We can xref this later once we have a page that goes into more details on that
| ```yaml | ||
| build: | ||
| ignore_run_exports: | ||
| # 'vs' run export left |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does "left" mean here?
|
|
||
| </RecipeTabs> | ||
|
|
||
| ## General-purpose build systems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same naming concern as in #2701; I'd prefer "build orchestrator"
| This section is focused on build systems that are not limited to a specific ecosystem, but include | ||
| support for multiple programming languages. | ||
|
|
||
| ### GNU autoconf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be first IMO. Definitely after CMake

PR Checklist:
docs/orcommunity/, you have added it to the sidebar in the corresponding_sidebar.jsonfilePer @jaimergp 's suggestion.