Skip to content

Conversation

@uilianries
Copy link
Member

@uilianries uilianries commented Oct 3, 2025

Description of your Pull Request

The issue #35 brings the case when an empty patch is tried to be applied, it fails in the end.

This is a scenario when doing chmod or similar only to a file, where no line is changed in the end. As a result, patch-ng can not understand it as it parser looks for the index @@ -0,0 +1 @@ (and similar).

This PR provides a test to validate that case, but does not bring a solution, because it will affect not only the patch parse logic profoundly, but also its regex. I'm afraid is too risky trying to fix it, but without breaking something else later, as this fork is supposed to be more conservative.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've tested locally that my code works.
  • I've added relevant tests to verify that my code works.

Signed-off-by: Uilian Ries <uilianr@jfrog.com>
Signed-off-by: Uilian Ries <uilianr@jfrog.com>
@uilianries uilianries merged commit 283d7fa into conan-io:master Oct 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant