MMMM-206: Fix Deprecated Settings Usage#91
Open
shahrukh-compuco wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the retrieval of CiviCRM settings by fetching individual settings such as 'invoicing', 'tax_display_settings', and 'tax_term' instead of the combined 'contribution_invoice_settings' array. Feedback suggests optimizing performance by caching these settings using static variables or object state to avoid redundant API calls within loops.
erawat
approved these changes
May 18, 2026
Member
erawat
left a comment
erawat
left a comment
There was a problem hiding this comment.
Review: Approve ✔
Correct replacement of deprecated contribution_invoice_settings array access with individual setting lookups (invoicing, tax_display_settings, tax_term). Consistent with existing wf_crm_get_civi_setting() patterns in this codebase.
Minor notes (non-blocking)
- SUGGESTION —
wf_crm_webform_preprocess.inc:580:$taxTermis fetched unconditionally but only used inside theifblock on line 582. Could be lazy-loaded inside the condition for cleanliness (settings are cached so no real perf impact). - WARNING — PR description only has "Overview" section. The template requires Before, After, and Technical Details sections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes the deprecated
contribution_invoice_settingsusage and replaces it with actual individual settings.