Issue 1031 joinOuterMerge#1419
Draft
rnjtranjan wants to merge 2 commits intoissue_1031_joinLeftMergefrom
Draft
Conversation
adithyaov
reviewed
Jan 10, 2022
Member
adithyaov
left a comment
adithyaov
left a comment
There was a problem hiding this comment.
Is it possible to use a custom data type in the state and document it. It would be much easier to understand/review.
Comment on lines
+480
to
+483
| joinOuterMerge eq s1 = | ||
| IsStream.fromStreamD | ||
| . StreamD.joinOuterMerge eq (IsStream.toStreamD s1) | ||
| . IsStream.toStreamD |
Member
There was a problem hiding this comment.
Instead of a point free notation, having s2 here seems more eloquent.
Comment on lines
+4034
to
+4035
| {-# INLINE_LATE step #-} | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| {-# INLINE_LATE step #-} | |
| {-# INLINE_LATE step #-} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.