Skip to content

Conversation

@inverse
Copy link
Contributor

@inverse inverse commented Sep 19, 2025

Saw the comment on #380 (comment) and looked into why this is happening.

Looks like its caused by the dependencyDashboardApproval flag being set to true by default causing this behaviour.

Tried it on one of my repos and it did work https://github.com/inverse/cert-host-scraper

But I saw some rate limiting due to there being quite a few to create initially.

@alcohol alcohol merged commit 70bb8e7 into composer:main Sep 22, 2025
1 check passed
@alcohol
Copy link
Member

alcohol commented Sep 22, 2025

Cheers! Was this documented somewhere? Do you have a link to the docs maybe?

@alcohol
Copy link
Member

alcohol commented Sep 22, 2025

It doesn't look like is enabled by default? Or maybe I misread; https://docs.renovatebot.com/key-concepts/dashboard/#dependency-dashboard-approval-workflow

@inverse inverse deleted the patch-1 branch September 22, 2025 18:12
@inverse
Copy link
Contributor Author

inverse commented Sep 22, 2025

When I saw that too I thought it was disabled by default. Especially since we are extending config:recommended and it outlines the following:

To require manual approval for all updates, add the :dependencyDashboardApproval presets to the extends array in your Renovate configuration file:

src: https://docs.renovatebot.com/key-concepts/dashboard/#require-approval-for-all-updates

What made me realise this wasn't the case was from the mend debug log on their platform I saw things like

DEBUG: Branch renovate/pytest-8.x-lockfile creation is disabled because dependencyDashboardApproval=true

Which made me look into how to explicitly disable it, which lead to that PR.

Is it just me or is configuring this tool to make it work as expected is quite painful? Especially if from reading the docs the reality of the behaviour doesn't match.

@alcohol
Copy link
Member

alcohol commented Sep 23, 2025

Is it just me or is configuring this tool to make it work as expected is quite painful? Especially if from reading the docs the reality of the behaviour doesn't match.

It's definitely not just you 🫣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants