Extension redesign#126
Open
TamaraBogantseva wants to merge 5 commits into
Open
Conversation
Signed-off-by: TamaraBogantseva <tamara.bogantseva@compose.us>
Signed-off-by: TamaraBogantseva <tamara.bogantseva@compose.us>
Signed-off-by: TamaraBogantseva <tamara.bogantseva@compose.us>
Signed-off-by: TamaraBogantseva <tamara.bogantseva@compose.us>
Signed-off-by: TamaraBogantseva <tamara.bogantseva@compose.us>
Narigo
reviewed
May 7, 2026
Member
Narigo
left a comment
Narigo
left a comment
There was a problem hiding this comment.
ice-servers-credentials/extension and ice-servers-credentials should be the same - always check for API key and we allow generic ones for DEMO and EXTENSION_TEST for now
| 'Access-Control-Allow-Origin': '*', | ||
| 'Access-Control-Allow-Methods': allowedMethods.join(','), | ||
| 'Access-Control-Allow-Headers': '*', | ||
| 'Access-Control-Allow-Headers': 'Authorization, Content-Type, *', |
Member
There was a problem hiding this comment.
If there is *, shouldn't it be enough anyways?
| : { 'Access-Control-Allow-Origin': '*' }), | ||
| 'Access-Control-Allow-Methods': allowedMethods.join(','), | ||
| 'Access-Control-Allow-Headers': '*', | ||
| 'Access-Control-Allow-Headers': 'Authorization, Content-Type, *', |
Member
There was a problem hiding this comment.
Same as above, * should match both of them as well?
Narigo
reviewed
May 7, 2026
Comment on lines
+2
to
4
| // Currently a no-op: /ice-server-credentials no longer reads this flag. | ||
| // Kept for the admin /server-control UI and for future per-license TURN gating. | ||
| let useTurnServer = false; |
Member
There was a problem hiding this comment.
"no dead code" in the CLAUDE.md file but it left this in? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesigns the Chrome extension popup, adds iframe and password field support, and ships managed TURN handling.