fix: should skip region instead of failing#15
Merged
gusfcarvalho merged 7 commits intomainfrom May 7, 2026
Merged
Conversation
…lable Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
There was a problem hiding this comment.
Pull request overview
This PR adjusts the AWS network diagnostics behavior so that unreachable AWS service endpoints no longer hard-fail an entire run. Instead, diagnostics are collected as warnings, concrete region lists are narrowed to reachable regions before running Cloud Custodian, and evaluation can continue to later checks while still returning aggregated diagnostic errors after evidence submission.
Changes:
- Change AWS endpoint network diagnostics from “fail-fast” to “warn + continue”, while still failing on invalid configured endpoints.
- Narrow
aws_regionsto only those with reachable service endpoints (and skip a check if all requested concrete regions are unreachable). - Plumb diagnostic warnings through execution results and update tests to cover the new behavior (including evidence submission before returning diagnostic failures).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
README.md |
Updates custodian_network_diagnostics behavior documentation to reflect warn/skip/narrow semantics. |
main.go |
Implements diagnostic result tracking, region narrowing/skip logic, and propagates diagnostic warnings into the Eval loop. |
main_test.go |
Updates/extends tests for diagnostics warn-and-continue, region filtering, and Eval behavior with diagnostic warnings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.