Skip to content

fix: should skip region instead of failing#15

Merged
gusfcarvalho merged 7 commits intomainfrom
gc-fix-skip-instead-of-fail
May 7, 2026
Merged

fix: should skip region instead of failing#15
gusfcarvalho merged 7 commits intomainfrom
gc-fix-skip-instead-of-fail

Conversation

@gusfcarvalho
Copy link
Copy Markdown
Contributor

No description provided.

…lable

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Copilot AI review requested due to automatic review settings May 7, 2026 15:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the AWS network diagnostics behavior so that unreachable AWS service endpoints no longer hard-fail an entire run. Instead, diagnostics are collected as warnings, concrete region lists are narrowed to reachable regions before running Cloud Custodian, and evaluation can continue to later checks while still returning aggregated diagnostic errors after evidence submission.

Changes:

  • Change AWS endpoint network diagnostics from “fail-fast” to “warn + continue”, while still failing on invalid configured endpoints.
  • Narrow aws_regions to only those with reachable service endpoints (and skip a check if all requested concrete regions are unreachable).
  • Plumb diagnostic warnings through execution results and update tests to cover the new behavior (including evidence submission before returning diagnostic failures).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
README.md Updates custodian_network_diagnostics behavior documentation to reflect warn/skip/narrow semantics.
main.go Implements diagnostic result tracking, region narrowing/skip logic, and propagates diagnostic warnings into the Eval loop.
main_test.go Updates/extends tests for diagnostics warn-and-continue, region filtering, and Eval behavior with diagnostic warnings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread main.go
Comment thread main.go Outdated
Comment thread main.go Outdated
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread main.go
Comment thread main.go Outdated
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread main.go Outdated
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comment thread main.go Outdated
Comment thread main.go Outdated
Comment thread main.go Outdated
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comment thread README.md Outdated
Comment thread main.go Outdated
Comment thread main.go Outdated
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread main.go Outdated
Comment thread main.go
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@gusfcarvalho gusfcarvalho merged commit d3bb7cb into main May 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants