Fix/kqueue waker#929
Open
paddor wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Rebasing... |
paddor
force-pushed
the
fix/kqueue-waker
branch
2 times, most recently
from
5337326 to
9bb54e4
Compare
polling's Events::is_empty() filters NOTIFY_KEY events, so a Poller::notify() wakeup produces an empty event set. Check the AwakeFlag's NOTIFIED bit after wait() returns to detect this case and return Ok(()) instead of ETIMEDOUT. Fixes compio-rs#928
Contributor
Author
|
Should be ready. |
Member
|
Thanks, @paddor . However, the tests you provided still pass even if the driver had not been modified. |
Contributor
Author
|
This is not the fix. More info coming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.