fix: scope now allows usage of dots #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddluke
force-pushed
the
fix/allow-dots-in-scope
branch
from
9aab75f to
10d1e31
Compare
ddluke
changed the title
thekaveman
requested changes
Oct 8, 2025
Member
thekaveman
left a comment
thekaveman
left a comment
There was a problem hiding this comment.
Thank you @ddluke this looks great! Just one small suggestion.
conventional_pre_commit/format.py
Outdated
| return r"(\([\w \/:,-\.]+\))?" | ||
| else: | ||
| return r"(\([\w \/:,-]+\))" | ||
| return r"(\([\w \/:,-\.]+\))" |
Member
There was a problem hiding this comment.
What do you think about pulling out escaped_delimiters from the if block above, to be able to reuse it here? I guess I didn't realize we listed these in multiple places, probably a good idea to have them once.
thekaveman
approved these changes
Oct 10, 2025
Member
thekaveman
left a comment
thekaveman
left a comment
There was a problem hiding this comment.
Great work, thank you @ddluke!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139
Description
This PR changes the formatter to allow dots in scopes. This can help a lot to more clearly express the scope of a change, especially in mono repositories with nested packages to use a
<domain>.<subdomain>like syntax