fix: skip merge commits patterns #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekaveman
approved these changes
Apr 29, 2025
Member
thekaveman
left a comment
thekaveman
left a comment
There was a problem hiding this comment.
Fantastic, thank you for the clean implementation and the tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #132
Closes #133
Description:
Improved the is_merge method to detect a broader range of standard Git merge commit formats. Instead of checking only for merge branch, it now supports:
Relevant test cases have been added to ensure robustness.
Motivation:
This avoids false positives from the Conventional Commit hook when developers use standard merge commits in workflows (e.g. merging main into feature branches).