[requires CppInterOp 1.9.0 release] Use Cpp::GetLanguage to set language#462
Merged
JohanMabille merged 1 commit intocompiler-research:mainfrom Apr 1, 2026
Conversation
mcbarton
force-pushed
the
detect-language-via-cppinterop
branch
2 times, most recently
from
da90ecb to
1c47973
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mcbarton
force-pushed
the
detect-language-via-cppinterop
branch
2 times, most recently
from
d060d19 to
b734e40
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
==========================================
- Coverage 80.56% 78.41% -2.15%
==========================================
Files 21 21
Lines 854 885 +31
Branches 80 80
==========================================
+ Hits 688 694 +6
- Misses 166 191 +25
🚀 New features to boost your workflow:
|
mcbarton
force-pushed
the
detect-language-via-cppinterop
branch
from
072f8fa to
282fef4
Compare
mcbarton
force-pushed
the
detect-language-via-cppinterop
branch
2 times, most recently
from
165250a to
827a9c5
Compare
mcbarton
force-pushed
the
detect-language-via-cppinterop
branch
from
827a9c5 to
3da73a0
Compare
JohanMabille
reviewed
Apr 1, 2026
Collaborator
JohanMabille
left a comment
JohanMabille
left a comment
There was a problem hiding this comment.
Same question as for #461 , why not simply using the argument passed to the CLI?
Collaborator
|
As discussed "in person", this will be moved into cppinterop, so let's merge for now since it"s fixing issues for the C kernel. |
JohanMabille
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With CppInterOp 1.9.0, an API was created which can detect the language of the interpreter (Cpp::GetLanguage). This PR uses this API to set the language, rather than it being static to C++, which will be incorrect for the C kernels. This PR needs testing and I will check it in the coming days.