implement sub-interpreters by Vipul-Cariappa · Pull Request #380 · compiler-research/xeus-cpp

Vipul-Cariappa · 2025-09-25T14:27:17Z

Description

Implements a way to create sub-interpreter and use them with in a notebook session.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

Bug fix
New feature
Added/removed dependencies
Required documentation updates

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 12. Check the log or trigger a new build to see more.

github-actions · 2025-09-25T15:05:29Z

src/xinterpreter.cpp

 #include "xsystem.hpp"

+#include "xmagics/multi_interpreter.hpp"
+


warning: included header multi_interpreter.hpp is not used directly [misc-include-cleaner]

Suggested change

github-actions · 2025-09-25T15:05:30Z

src/xmagics/multi_interpreter.cpp

+#include "multi_interpreter.hpp"
+
+#include <iostream>
+#include <iterator>


warning: included header iostream is not used directly [misc-include-cleaner]

Suggested change

#include <iterator>

#include <iterator>

github-actions · 2025-09-25T15:05:30Z

src/xmagics/multi_interpreter.cpp

+
+#include <iostream>
+#include <iterator>
+#include <sstream>


warning: included header iterator is not used directly [misc-include-cleaner]

Suggested change

#include <sstream>

#include <sstream>

github-actions · 2025-09-25T15:05:30Z

src/xmagics/multi_interpreter.cpp

+#include <sstream>
+#include <string>
+#include <vector>
+


warning: included header vector is not used directly [misc-include-cleaner]

Suggested change

github-actions · 2025-09-25T15:05:30Z

src/xmagics/multi_interpreter.cpp

+
+static std::vector<std::string> split(const std::string& input)
+{
+    std::istringstream buffer(input);


warning: unused local variable 'buffer' of type 'std::istringstream' (aka 'basic_istringstream') [bugprone-unused-local-non-trivial-variable]

std::istringstream buffer(input); ^

github-actions · 2025-09-25T15:05:30Z

src/xmagics/multi_interpreter.cpp

+    return ret;
+}
+
+static constexpr size_t len(std::string_view n)


warning: no header providing "size_t" is directly included [misc-include-cleaner]

src/xmagics/multi_interpreter.cpp:10:

- #include <iostream> + #include <cstddef> + #include <iostream>

github-actions · 2025-09-25T15:05:31Z

src/xmagics/multi_interpreter.cpp

+    return ret;
+}
+
+static constexpr size_t len(std::string_view n)


warning: no header providing "std::string_view" is directly included [misc-include-cleaner]

src/xmagics/multi_interpreter.cpp:14:

- #include <vector> + #include <string_view> + #include <vector>

github-actions · 2025-09-25T15:05:31Z

src/xmagics/multi_interpreter.hpp

+ ************************************************************************************/
+
+#ifndef XEUS_CPP_MULTI_INTERPRETER_MAGIC_HPP
+#define XEUS_CPP_MULTI_INTERPRETER_MAGIC_HPP


warning: header guard does not follow preferred style [llvm-header-guard]

Suggested change

#define XEUS_CPP_MULTI_INTERPRETER_MAGIC_HPP

#ifndef GITHUB_WORKSPACE_SRC_XMAGICS_MULTI_INTERPRETER_HPP

#define GITHUB_WORKSPACE_SRC_XMAGICS_MULTI_INTERPRETER_HPP

src/xmagics/multi_interpreter.hpp:32:

- #endif // XEUS_CPP_MULTI_INTERPRETER_MAGIC_HPP + #endif // GITHUB_WORKSPACE_SRC_XMAGICS_MULTI_INTERPRETER_HPP

github-actions · 2025-09-25T15:05:31Z

src/xmagics/multi_interpreter.hpp

+
+#include <string>
+#include <unordered_map>
+


warning: included header unordered_map is not used directly [misc-include-cleaner]

Suggested change

github-actions · 2025-09-25T15:05:31Z

src/xmagics/multi_interpreter.hpp

+#include <string>
+#include <unordered_map>
+
+#include "CppInterOp/CppInterOp.h"


warning: 'CppInterOp/CppInterOp.h' file not found [clang-diagnostic-error]

#include "CppInterOp/CppInterOp.h" ^

github-actions

clang-tidy made some suggestions

github-actions · 2025-09-26T08:02:42Z

src/xmagics/multi_interpreter.hpp

+    {
+    public:
+
+        XEUS_CPP_API


warning: no header providing "XEUS_CPP_API" is directly included [misc-include-cleaner]

src/xmagics/multi_interpreter.hpp:15:

- #include "xeus-cpp/xmagics.hpp" + #include "xeus-cpp/xeus_cpp_config.hpp" + #include "xeus-cpp/xmagics.hpp"

github-actions · 2025-09-26T08:02:42Z

src/xmagics/multi_interpreter.hpp

+
+    private:
+
+        std::unordered_map<std::string, Cpp::TInterp_t> interpreters;


warning: invalid case style for private member 'interpreters' [readability-identifier-naming]

Suggested change

std::unordered_map<std::string, Cpp::TInterp_t> interpreters;

std::unordered_map<std::string, Cpp::TInterp_t> m_interpreters;

mcbarton · 2025-09-26T15:50:43Z

Please add some tests to this PR

github-actions

clang-tidy made some suggestions

github-actions · 2026-03-26T09:49:27Z

src/xmagics/multi_interpreter.cpp

+        }
+        else
+        {
+            auto named = std::find(Args0.begin(), Args0.end(), "--name");


warning: no header providing "std::find" is directly included [misc-include-cleaner]

src/xmagics/multi_interpreter.cpp:10:

- #include <iostream> + #include <algorithm> + #include <iostream>

github-actions · 2026-03-26T09:49:27Z

src/xmagics/multi_interpreter.cpp

+        }
+        if (I)
+        {
+            Cpp::Declare(cell.c_str(), false, I);


warning: too many arguments to function call, expected at most 2, have 3 [clang-diagnostic-error]

Cpp::Declare(cell.c_str(), false, I); ^

Additional context

/github/home/micromamba/envs/xeus-cpp/include/CppInterOp/CppInterOp.h:771: 'Declare' declared here

CPPINTEROP_API int Declare(const char* code, bool silent = false); ^

github-actions bot reviewed Sep 25, 2025

View reviewed changes

mcbarton force-pushed the dev/multi-interp branch from b20deed to 63271f0 Compare September 26, 2025 07:55

mcbarton mentioned this pull request Sep 26, 2025

Add C23 Kernel #379

Merged

4 tasks

github-actions bot reviewed Sep 26, 2025

View reviewed changes

Vipul-Cariappa force-pushed the dev/multi-interp branch from 63271f0 to 4a612cc Compare March 26, 2026 09:42

github-actions bot reviewed Mar 26, 2026

View reviewed changes

Vipul-Cariappa added 2 commits March 26, 2026 10:51

implement sub-interpreters

ddc6907

add example notebook

978dbe6

Vipul-Cariappa force-pushed the dev/multi-interp branch from 4a612cc to 978dbe6 Compare March 26, 2026 09:51

		#include "xsystem.hpp"

		#include "xmagics/multi_interpreter.hpp"

	#define XEUS_CPP_MULTI_INTERPRETER_MAGIC_HPP
	#ifndef GITHUB_WORKSPACE_SRC_XMAGICS_MULTI_INTERPRETER_HPP
	#define GITHUB_WORKSPACE_SRC_XMAGICS_MULTI_INTERPRETER_HPP


		private:

		std::unordered_map<std::string, Cpp::TInterp_t> interpreters;

Conversation

Vipul-Cariappa commented Sep 25, 2025

Description

Fixes # (issue)

Type of change

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

mcbarton commented Sep 26, 2025

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants