Feat: support input sam files for conversion time benchmarks#52
Open
neo-0007 wants to merge 1 commit intocompiler-research:developfrom
Open
Feat: support input sam files for conversion time benchmarks#52neo-0007 wants to merge 1 commit intocompiler-research:developfrom
neo-0007 wants to merge 1 commit intocompiler-research:developfrom
Conversation
currently synthetic SAM files are generated for conversion benchmark Now we will be able to give our own input sam files ( real data ) as args and get the benchmark results Signed-off-by: Hrishikesh Gohain <hrishikeshgohain123@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #52 +/- ##
===========================================
+ Coverage 64.78% 64.85% +0.06%
===========================================
Files 16 16
Lines 1525 1525
Branches 632 632
===========================================
+ Hits 988 989 +1
Misses 462 462
+ Partials 75 74 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #include <iostream> | ||
| #include <cstdio> | ||
| #include <vector> | ||
| #include <string> |
There was a problem hiding this comment.
warning: included header vector is not used directly [misc-include-cleaner]
Suggested change
| #include <string> | |
| #include <string> |
| { | ||
| auto file_index = static_cast<std::size_t>(state.range(0)); | ||
| std::string sam_file = input_files[file_index]; | ||
| std::string rntuple_file = sam_file + ".rntuple.root"; |
There was a problem hiding this comment.
warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
std::string rntuple_file = sam_file + ".rntuple.root";
^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synthetic SAM files were generated for conversion benchmark. Now we will be able to give our own input sam files ( real data ) as args and get the benchmark results.
We do not count the number of reads , so adding MB_per_sec which can be used for comparison
Suppressed some clang tidy suggestions , some can be changed but the code would need a lot of refactoring , still i can apply those suggestions if wanted.
The python bench-marking is present for this kind of use but it uses a .perf file for which generator is currently depreciated as it uses the past root macro based approach. And .perf files can only be created on Linux and maybe MacOS. I am open to fixing tools_perf.py and perf_utils.py if wanted. Thanks !