Chore clang-tidy warnings for ramcoretests.cxx#48
Draft
RedBlueBird wants to merge 4 commits intocompiler-research:developfrom
Draft
Chore clang-tidy warnings for ramcoretests.cxx#48RedBlueBird wants to merge 4 commits intocompiler-research:developfrom
RedBlueBird wants to merge 4 commits intocompiler-research:developfrom
Conversation
RedBlueBird
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #48 +/- ##
===========================================
+ Coverage 63.83% 65.00% +1.16%
===========================================
Files 16 16
Lines 1496 1546 +50
Branches 624 625 +1
===========================================
+ Hits 955 1005 +50
Misses 448 448
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes
🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,29 +1,29 @@ | |||
| #include "../benchmark/generate_sam_benchmark.h" | |||
| #include "../tools/ramview.cxx" | |||
There was a problem hiding this comment.
warning: suspicious #include of file with '.cxx' extension [bugprone-suspicious-include]
#include "../tools/ramview.cxx"
^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[PR is currently a Draft.]
Contributes to Issue #46.
Addressed all 100+
clang-tidywarnings intest\ramcoretests.cxxexcept 1.The warnings can be divided into the following categories:
# Includesare not sorted# Includesare not usedEndlis slower than\nThe only warning left from running
clang-tidy -p build test\ramcoretests.cxxiswhich says ramview.cxx should probably break into two parts: header + source pair.
To address this warning involves changing other files, and I will put a hold on this PR for now temporarily.