llvm-wasm: include lld-cmake-exports + lld-headers in DIST.#71
Merged
vgvassilev merged 1 commit intoMay 12, 2026
Merged
Conversation
The wasm install tree shipped liblldCommon.a / liblldWasm.a / liblldELF.a (picked up by `_walk_built_libs`) but no LLDConfig.cmake under lib/cmake/lld/. CppInterOp's wasm consumer passes `-DLLD_DIR=$LLVM_BUILD_DIR/lib/cmake/lld` and find_package(LLD) fails configure with "Could not find a package configuration file provided by LLD". Add `lld-cmake-exports` (writes lib/cmake/lld/LLDConfig.cmake) and `lld-headers` (writes include/lld/) to the wasm DIST set, mirroring how `clang-cmake-exports` + `clang-headers` cover the clang side. The corresponding install rules already exist in LLVM's lld/ tree; they just weren't listed in our DIST so `ninja install-distribution` skipped them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wasm install tree shipped liblldCommon.a / liblldWasm.a / liblldELF.a (picked up by
_walk_built_libs) but no LLDConfig.cmake under lib/cmake/lld/. CppInterOp's wasm consumer passes-DLLD_DIR=$LLVM_BUILD_DIR/lib/cmake/lldand find_package(LLD) fails configure with "Could not find a package configuration file provided by LLD".Add
lld-cmake-exports(writes lib/cmake/lld/LLDConfig.cmake) andlld-headers(writes include/lld/) to the wasm DIST set, mirroring howclang-cmake-exports+clang-headerscover the clang side. The corresponding install rules already exist in LLVM's lld/ tree; they just weren't listed in our DIST soninja install-distributionskipped them.