Fix: JitCall codegen for deleted copy ctor in args#971
Open
Vipul-Cariappa wants to merge 1 commit into
Open
Conversation
Change to use move constructor when the copy constructor is deleted amoung the arguments to an constructor.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #971 +/- ##
==========================================
+ Coverage 81.79% 81.98% +0.18%
==========================================
Files 15 15
Lines 4779 4796 +17
==========================================
+ Hits 3909 3932 +23
+ Misses 870 864 -6
🚀 New features to boost your workflow:
|
vgvassilev
approved these changes
May 5, 2026
| return false; | ||
| } | ||
|
|
||
| RD = RD->getDefinition(); |
Contributor
There was a problem hiding this comment.
We can add complete type call to the cppinterop interfaces which has probably a raii object as this operation might trigger deserialization.
Comment on lines
+2585
to
+2589
| for (auto* Ctor : RD->ctors()) { | ||
| if (Ctor->isCopyConstructor()) { | ||
| return Ctor->isDeleted(); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| for (auto* Ctor : RD->ctors()) { | |
| if (Ctor->isCopyConstructor()) { | |
| return Ctor->isDeleted(); | |
| } | |
| } | |
| for (auto* Ctor : RD->ctors()) | |
| if (Ctor->isCopyConstructor()) | |
| return Ctor->isDeleted(); | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change to use the move constructor when the copy constructor is deleted among the arguments to a constructor.
Moves closer to what Cling does.
Fixes # (issue)
ROOT tests.
Type of change
Please tick all options which are relevant.
Testing
Checklist