Fix: GetEnumConstantValue when value can't be within int64_t#970
Open
Vipul-Cariappa wants to merge 1 commit into
Open
Fix: GetEnumConstantValue when value can't be within int64_t#970Vipul-Cariappa wants to merge 1 commit into
Vipul-Cariappa wants to merge 1 commit into
Conversation
Vipul-Cariappa
commented
May 5, 2026
| return INTEROP_RETURN(Val.getExtValue()); | ||
| llvm::SmallString<40> StrVal; | ||
| Val.toString(StrVal); | ||
| return INTEROP_RETURN(std::stoul(StrVal.c_str())); |
Collaborator
Author
There was a problem hiding this comment.
Do we need macro to check if sizeof(unsigned long) == sizeof(size_t) then call stoul, else if sizeof(unsigned long long) == sizeof(size_t), call stoull? For all the systems we are interested (64 bit), I believe sizeof(unsigned long) == sizeof(unsigned long long) == 64. Then we will also have to change the return type. What is the enum value is negative...!?
Collaborator
Author
There was a problem hiding this comment.
what if int128_t https://godbolt.org/z/zv758P33a?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
==========================================
+ Coverage 81.79% 81.81% +0.01%
==========================================
Files 15 15
Lines 4779 4783 +4
==========================================
+ Hits 3909 3913 +4
Misses 870 870
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.