Only inject -resource-dir when we actually have a path#950
Open
guitargeek wants to merge 1 commit into
Open
Conversation
guitargeek
changed the title
-resource-dir when we actually have a path-resource-dir when we actually have a path
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #950 +/- ##
==========================================
- Coverage 81.76% 81.74% -0.02%
==========================================
Files 15 15
Lines 4759 4760 +1
==========================================
Hits 3891 3891
- Misses 868 869 +1
... and 1 file with indirect coverage changes
🚀 New features to boost your workflow:
|
Only inject -resource-dir when we actually have a path. An empty value would cause clang to consume the next argument (e.g. "-std=c++14") as the resource-dir value, silently dropping it. This fixes running the tests in my setup where I use a different Clang version as the default on the system from the one I build CppInterOp against. This makes `DetectResourceDir()` fail because it just uses the `clang` executable. One could imagine also to improve `DetectResourceDir()` to deal with this case, but it's not necessary for now because my setup also works without passing `-resource-dir` at all (using CppInterOp inside ROOT with Cling).
vgvassilev
reviewed
May 2, 2026
Comment on lines
+3816
to
+3818
| if (!ResourceDir.empty()) { | ||
| ClingArgv.insert(ClingArgv.begin(), {"-resource-dir", ResourceDir.c_str()}); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!ResourceDir.empty()) { | |
| ClingArgv.insert(ClingArgv.begin(), {"-resource-dir", ResourceDir.c_str()}); | |
| } | |
| if (!ResourceDir.empty()) | |
| ClingArgv.insert(ClingArgv.begin(), {"-resource-dir", ResourceDir.c_str()}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only inject -resource-dir when we actually have a path. An empty value would cause clang to consume the next argument (e.g. "-std=c++14") as the resource-dir value, silently dropping it.
This fixes running the tests in my setup where I use a different Clang version as the default on the system from the one I build CppInterOp against. This makes
DetectResourceDir()fail because it just uses theclangexecutable. One could imagine also to improveDetectResourceDir()to deal with this case, but it's not necessary for now because my setup also works without passing-resource-dirat all (using CppInterOp inside ROOT with Cling).