Delete include/clang/Interpreter/CppInterOp.h#882
Open
mcbarton wants to merge 4 commits intocompiler-research:mainfrom
Open
Delete include/clang/Interpreter/CppInterOp.h#882mcbarton wants to merge 4 commits intocompiler-research:mainfrom
mcbarton wants to merge 4 commits intocompiler-research:mainfrom
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
=======================================
Coverage 80.90% 80.90%
=======================================
Files 13 13
Lines 4593 4593
=======================================
Hits 3716 3716
Misses 877 877 🚀 New features to boost your workflow:
|
Contributor
|
we also need to rename the binary artifact from libclangCppInterOp to libCppInterOp. |
Collaborator
Author
I will do that in a follow up PR, since that requires more work. xeus-cpp and cppyy already have this header renamed to the new one. renaming the library will require work throughout the organisation. |
Contributor
|
I think it needs to happen in one PR. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
mcbarton
force-pushed
the
Remove-old-header
branch
from
f33658b to
5dce951
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the next version has been labelled as version 2, and breaking changes are implied, it might be worth taking this opportunity to delete the deprecated
clang/Interpreter/CppInterOp.hheader.