Skip to content

COMPAS-2.x.LTS: Tolerance bugfix#1513

Open
chenkasirer wants to merge 5 commits intoCOMPAS-2.x.LTSfrom
tolerance_bugfix
Open

COMPAS-2.x.LTS: Tolerance bugfix#1513
chenkasirer wants to merge 5 commits intoCOMPAS-2.x.LTSfrom
tolerance_bugfix

Conversation

@chenkasirer
Copy link
Member

@chenkasirer chenkasirer commented Mar 18, 2026

Cherry-picked the changes to Tolerance from main as I believe this should be released as patch on LTS 2.x

  • removed implicit singleton behavior of Tolerance. Independent instances can be created and global instance needs to be explicitly modified
  • Fixed some typos in a backwards compatible manner, with user warnings.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 72.97297% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.35%. Comparing base (e34268a) to head (13febbe).

Files with missing lines Patch % Lines
src/compas/tolerance.py 72.97% 20 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           COMPAS-2.x.LTS    #1513      +/-   ##
==================================================
+ Coverage           62.26%   62.35%   +0.09%     
==================================================
  Files                 208      208              
  Lines               22452    22502      +50     
==================================================
+ Hits                13979    14031      +52     
+ Misses               8473     8471       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant