Added initial code for density maps#83
Open
artajmir3 wants to merge 11 commits intocompSPI:masterfrom
Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Open
ninamiolane
requested changes
May 9, 2022
Contributor
ninamiolane
left a comment
ninamiolane
left a comment
There was a problem hiding this comment.
@artajmir3 thank you so much for your PR!
Could add a test for your notebook, by copy-pasting the file test_notebooks.py here:
https://github.com/compSPI/ioSPI/pull/75/files#diff-c12d9e359c589e405a132b291f892d640e0fd4b9bc459759d91f152ddc8c5571
If this passes, then we can merge. Thanks for the great work!
Contributor
|
Marking as draft for now since the tests are not passing. Some indications:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added initial code for reading a density map from a .mrc file.
Added corresponding tests.
Added a Jupyter notebook for test and visualization.