♻️ refactor(HostedCart): fix hooks order, extract domain constant and url resolver#772
Merged
Merged
Conversation
… url resolver, use useCallback - Move all useContext calls above early return to fix Rules of Hooks violation - Extract DEFAULT_DOMAIN constant to remove hardcoded duplicate strings - Extract resolveCartUrl() helper to deduplicate getOrganizationConfig + getApplicationLink logic - Fix missing customDomain in the useEffect getApplicationLink call - Wrap onMessage with useCallback and fix useEffect dependency ([onMessage] instead of [ref.current != null]) - Update JSDoc: OrderContainer → Order - Remove commented-out zIndex lines from default styles Closes #771 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
HostedCart.tsxto fix bugs and align with the patterns established inCheckoutLinkandCartLink.Changes
useContext(OrderContext)anduseContext(OrderStorageContext)were called after an earlyreturn null, violating React's rules of hooks. All hooks now sit above the early return.DEFAULT_DOMAINconstant — removes the two hardcoded'commercelayer.io'stringsresolveCartUrl()helper — deduplicates thegetOrganizationConfig+getApplicationLinklogic that was repeated in bothsetOrderand the mainuseEffectcustomDomain— the directgetApplicationLinkcall insideuseEffectwas not forwarding the prop; now it goes throughresolveCartUrlonMessagewithuseCallbackand fix the iframe resizeruseEffectdep array ([onMessage]instead of the invalid[ref.current != null])<OrderContainer>with<Order>// zIndexlines in default stylesCloses #771