Temporarily relax biome setup for v4 #694
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for commercelayer-react-components failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Modified the
biomesetup to disable several rules and applied a little bunch of changes to the code to let the library raise a lower amount of linting errors.The idea is that we are moving to a new major version of the library and we have not in plan to make big changes to the v4 version to avoid the need of refactoring and retesting a big amount of stuff that should be upgraded to fulfill the standard strict linting rules in a project that is going to be upgraded.
The PR is still not able to pass the biome checks because it is blocked by 8 final issues that I left to be checked together because they are related to some unused punctual ignore rules with comments by Ale that in case could be removed being actually covered by my updated permissive biome setup. I don't know if we care about the comments so I waited for your check to remove them.