Presever other values in HookedInputCheckboxGroup#1149
Open
gciotola wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for commercelayer-app-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
gciotola
changed the title
HookedInputCheckboxGroup
gciotola
force-pushed
the
fix/625-input-checkbox-group
branch
from
320ad04 to
ca88e9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to commercelayer/issues-app#625
Description
Fix
HookedInputCheckboxGroupstripping consumer-defined extra fields (e.g.reason) from form state when a checkbox is toggled. TheonChangehandler now merges incomingSelectedItem[]with the existingfield.value, preserving any extra properties set viasetValue.Added an
Array.isArrayguard with per-item shape validation to safely handle malformed form state.