Skip to content

Schema editor rename index support for sqlite3, mysql, mariadb and SQL server #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eug3nix merged 2 commits into from
Mar 5, 2026
Merged

Schema editor rename index support for sqlite3, mysql, mariadb and SQL server #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d2fbe0
adds renameIndex support for sqlite3, mysql, mariadb and SQL server
plucik Feb 23, 2026
c79aead
fixes unnecessary "where null" block during rename when index doesn`t…
plucik Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pgmanage/app/static/pgmanage_frontend/src/components/SchemaEditorTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ export default {
omit(originalIndexes[idx], ['is_dirty']),
)

if(index.index_name !== originalIndexes[idx].index_name) indexChanges.renames.push({'oldName': originalIndexes[idx].index_name, 'newName': index.index_name})
if(index.index_name !== originalIndexes[idx].index_name) indexChanges.renames.push({'oldName': originalIndexes[idx].index_name, 'newName': index.index_name, indexDef: index})
})

let originalForeignKeys = this.initialForeignKeys
Expand Down Expand Up @@ -494,9 +494,8 @@ export default {
table.dropIndex(null, indexName)
})

// TODO: add renameIndex support on other database dialects
indexChanges.renames.forEach((rename) => {
table.renameIndex(rename.oldName, rename.newName)
table.renameIndex(rename.oldName, rename.newName, rename.indexDef)
})

foreignKeyChanges.drops.forEach((constraintName) => {
Expand Down
48 changes: 43 additions & 5 deletions pgmanage/app/static/pgmanage_frontend/src/components/dialect-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ import flatten from 'lodash/flatten';

knex.TableBuilder.extend(
"renameIndex",
function (oldIndexName, newIndexName) {
function (oldIndexName, newIndexName, indexDef) {
this._statements.push({
grouping: "alterTable",
method: "renameIndex",
args: [oldIndexName, newIndexName],
args: [oldIndexName, newIndexName, indexDef],
});
}
);
Expand Down Expand Up @@ -82,7 +82,6 @@ export default Object.freeze({
alterColumn: true,
multiStatement: true,
multiPrimaryKeys: true,
renameIndex: true,
indexMethod: true,
addForeignKey: true,
dropForeignKey: true,
Expand All @@ -102,6 +101,29 @@ export default Object.freeze({
})
}
},
() => {
TableCompiler_SQLite3.prototype.renameIndex = function (from, to, indexDef) {
this.dropIndex(null, from);

const qb = knex({ client: this.client.dialect });

const strippedPredicate = indexDef.predicate != null ? indexDef.predicate.trimStart().replace(/^where/i, "") : "";
if (indexDef.type === "unique") {
this.unique(indexDef.columns, {
indexName: indexDef.index_name,
useConstraint: false,
predicate: qb.where(qb.raw(strippedPredicate)),
})
} else {
this.index(indexDef.columns, indexDef.index_name, {
indexType: indexDef.type === 'non-unique' ? '' : indexDef.type,
storageEngineIndexType: null,
predicate: qb.where(qb.raw(strippedPredicate)),
}
)
}
};
},
],
},
'mysql': {
Expand Down Expand Up @@ -131,7 +153,6 @@ export default Object.freeze({
disabledFeatures: {
indexPredicate: true,
indexMethod: true,
renameIndex: true,
},
overrides: [
() => {
Expand Down Expand Up @@ -160,6 +181,17 @@ export default Object.freeze({
});
};
},
() => {
TableCompiler_MySQL.prototype.renameIndex = function (from, to) {
const table = this.tableName();
const sql = `ALTER TABLE ${table} RENAME INDEX ${this.formatter.wrap(
from
)} TO ${this.formatter.wrap(to)}`;
this.pushQuery({
sql: sql,
});
};
},
],
},
'mssql': {
Expand All @@ -185,7 +217,6 @@ export default Object.freeze({
},
disabledFeatures: {
indexMethod: true,
renameIndex: true,
},
overrides: [
() => {
Expand Down Expand Up @@ -234,6 +265,13 @@ export default Object.freeze({
});
}
},
() => {
TableCompiler_MSSQL.prototype.renameIndex = function(from, to) {
const indexNameFrom = `${this.tableName()}.${this.formatter.wrap(from)}`
const sql = `EXEC sp_rename '${indexNameFrom}', '${to}', 'INDEX'`
this.pushQuery(sql);
}
},
],
},
'oracle':{
Expand Down