Skip to content

Fix Accordion not reacting to checked changing #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sshane merged 1 commit into from
Dec 2, 2025
Merged

Fix Accordion not reacting to checked changing #261

sshane merged 1 commit into from
Dec 2, 2025

Conversation

@sshane
Copy link
Contributor

@sshane sshane commented Dec 2, 2025 •
edited
Loading

Fixes #256 (comment)

Seems like you can't have a two way checked binding, so need this

@sshane
fix
629331d 
cmt
@sshane sshane force-pushed the fix-accordion-reactive branch from f20cf93 to 629331d Compare December 2, 2025 21:29
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

deployed preview: https://comma-web--pr261-38ft9hev.web.app

Welcome! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

@sshane sshane merged commit 521ef71 into master Dec 2, 2025
4 checks passed
@sshane sshane deleted the fix-accordion-reactive branch December 2, 2025 21:47
adeebshihadeh added a commit that referenced this pull request Dec 3, 2025
@adeebshihadeh
Revert "Fix Accordion not reacting to checked changing (#261)"
7d04f92 
This reverts commit 521ef71.
@adeebshihadeh
Copy link
Collaborator

adeebshihadeh commented Dec 3, 2025

This completely broke accordions. How did this get merged?

@adeebshihadeh adeebshihadeh mentioned this pull request Dec 3, 2025
Closed
sshane added a commit that referenced this pull request Dec 3, 2025
@sshane
Reapply "Fix Accordion not reacting to checked changing (#261)"
18cc2d0 
This reverts commit 7d04f92.
sshane added a commit that referenced this pull request Dec 3, 2025
@sshane
Fix Accordion not reacting to checked changing (#264)
8359547 
* Reapply "Fix Accordion not reacting to checked changing (#261)"

This reverts commit 7d04f92.

* there's no better way?!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sshane @adeebshihadeh